Re: [PATCH v2 1/4] t4014: more tests about appending s-o-b lines
On Sat, Dec 1, 2012 at 11:06 PM, Torsten Bögershausen tbo...@web.de wrote: On 22.11.12 17:38, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- t/t4014-format-patch.sh | 145 1 file changed, 145 insertions(+) + echo -n subject | append_signoff actual echo -n is not portable, and we use printf everywhere. I found one echo -n in line 996. Can we squeeze that in, before going to next? I got it. I'll squash it into the next series. -Brandon -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/4] t4014: more tests about appending s-o-b lines
On 22.11.12 17:38, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- t/t4014-format-patch.sh | 145 1 file changed, 145 insertions(+) + echo -n subject | append_signoff actual echo -n is not portable, and we use printf everywhere. I found one echo -n in line 996. Can we squeeze that in, before going to next? diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 6cfad13..f460930 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -993,7 +993,7 @@ EOF ' test_expect_success 'signoff: commit with only subject that does not end with NL' ' - echo -n subject | append_signoff actual + printf subject | append_signoff actual cat expected \EOF 4:Subject: [PATCH] subject 8: -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
