Re: [PATCH v2 17/25] commit_lock_file(): make committing an unlocked lockfile a NOP

2014-04-14 Thread Michael Haggerty
On 04/07/2014 09:31 PM, Jeff King wrote: > On Mon, Apr 07, 2014 at 01:33:59AM +0200, Michael Haggerty wrote: > >> It was previously a bug to call commit_lock_file() with a lock_file >> object that was not active (an illegal access would happen within the >> function). It was presumably never done

Re: [PATCH v2 17/25] commit_lock_file(): make committing an unlocked lockfile a NOP

2014-04-07 Thread Jeff King
On Mon, Apr 07, 2014 at 01:33:59AM +0200, Michael Haggerty wrote: > It was previously a bug to call commit_lock_file() with a lock_file > object that was not active (an illegal access would happen within the > function). It was presumably never done, but this would be an easy > programming error