Re: [PATCH v2 2/2] t9813: avoid using pipes

2017-01-03 Thread Stefan Beller
> > git p4 commit >actual && > grep "git author de...@example.com does not match" actual && > > What do you think? >From the travis logs: 'actual.err' is not empty, it contains: ... - file(s) up-to-date. I think(/hope) such a progress is tested for at another test, and not relevant here

Re: [PATCH v2 2/2] t9813: avoid using pipes

2017-01-03 Thread Pranit Bauva
Hey Stefan, On Tue, Jan 3, 2017 at 11:28 PM, Stefan Beller wrote: > On Mon, Jan 2, 2017 at 10:45 AM, Pranit Bauva wrote: >> The exit code of the upstream in a pipe is ignored thus we should avoid >> using it. > > for commands under test, i.e. git

Re: [PATCH v2 2/2] t9813: avoid using pipes

2017-01-03 Thread Stefan Beller
On Mon, Jan 2, 2017 at 10:45 AM, Pranit Bauva wrote: > The exit code of the upstream in a pipe is ignored thus we should avoid > using it. for commands under test, i.e. git things. Other parts can be piped if that makes the test easier. Though I guess that can be guessed