Re: [PATCH v2 2/3] help: introduce option --exclude-guides

2016-08-26 22:20 GMT+02:00 Junio C Hamano : > > Because the whole thing is inside a double-quote pair, $() and $name > are all interpolated even before test_expect_success is called. > So the above becomes equivalent to > >>> test_expect_success "two commits do not have the same

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

Ralf Thielow writes: > 2016-08-26 21:42 GMT+02:00 Junio C Hamano : >> Junio C Hamano writes: >> >> >> Taking all of these together, I'll queue this as a proposed fix-up >> directly on top of yours. >> > > Thanks! Thank you for

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

Ralf Thielow writes: >>> As we pass a URL, Git won't check if the given path looks like >>> a documentation directory. Another solution would be to create >>> a directory, add a file "git.html" to it and just use this path. >> >> I think this is OK; with s|As we pass a

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

2016-08-26 21:42 GMT+02:00 Junio C Hamano : > Junio C Hamano writes: > > > Taking all of these together, I'll queue this as a proposed fix-up > directly on top of yours. > Thanks! -- To unsubscribe from this list: send the line "unsubscribe git" in the body

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

2016-08-26 21:06 GMT+02:00 Junio C Hamano : > Ralf Thielow writes: > >> Introduce option --exclude-guides to the help command. With this option >> being passed, "git help" will open man pages only for actual commands. > > Let's hide this option from

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

Junio C Hamano writes: > Let's hide this option from command help of "git help" itself, drop > the short-and-sweet "-e", not command-line complete it, and leave it > not-mentioned here. > ... > Unless there is a good reason you MUST do so, avoid quoting the test > body with

Re: [PATCH v2 2/3] help: introduce option --exclude-guides

Ralf Thielow writes: > Introduce option --exclude-guides to the help command. With this option > being passed, "git help" will open man pages only for actual commands. Let's hide this option from command help of "git help" itself, drop the short-and-sweet "-e", not