Re: [PATCH v2 2/3] rev-parse: be more careful with munging arguments

2013-12-09 Thread Eric Sunshine
On Fri, Dec 6, 2013 at 5:07 PM, Jeff King p...@peff.net wrote: When rev-parse looks at whether an argument like foo..bar or foobar^@ is a difference or parent-shorthand, it internally munges the arguments so that it can pass the individual rev arguments to get_sha1. However, we do not

Re: [PATCH v2 2/3] rev-parse: be more careful with munging arguments

2013-12-06 Thread Jonathan Nieder
Jeff King wrote: As an aside, this is one of those places where C's string functions do gross things with const. Yes, yuck. The fundamental grossness is that argv is semantically char ** (assuming this doesn't segfault) but passed around as const char **. I wonder why we don't use the same