Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

2018-03-15 23:47 GMT+03:00 Martin Ågren : > I skimmed the first four patches of this v2. It seems that patches 1 and > 4 are identical to v2. Patches 2 and 3 have very straightforward changes > based on my earlier comments. Let's see what this patch is about. :-) Yes, you

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

2018-03-16 0:01 GMT+03:00 Eric Sunshine : > On Thu, Mar 15, 2018 at 4:47 PM, Martin Ågren wrote: >> These are "real" errors and yield several more changes in the remainder. >> Ignoring those BUG-type messages at the beginning of this patch would >>

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

Martin Ågren writes: >> static int grab_objectname(const char *name, const unsigned char *sha1, >> - struct atom_value *v, struct used_atom *atom) >> + struct atom_value *v, struct used_atom *atom, >> +

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

On Thu, Mar 15, 2018 at 4:47 PM, Martin Ågren wrote: > These are "real" errors and yield several more changes in the remainder. > Ignoring those BUG-type messages at the beginning of this patch would > give a patch like the one below. > > +static int get_object(struct

Re: [PATCH v2 5/5] ref-filter: get_ref_atom_value() error handling

I skimmed the first four patches of this v2. It seems that patches 1 and 4 are identical to v2. Patches 2 and 3 have very straightforward changes based on my earlier comments. Let's see what this patch is about. :-) On 14 March 2018 at 20:04, Olga Telezhnaya wrote: >