Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-08 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 07, 2017 at 02:31:38PM -0800, Junio C Hamano wrote: > >> If this goes on top as a standalone patch, then the reason why it is >> separate from the other users of _default() is not because the way >> it uses the null return is special, but because it

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-08 Thread Jeff King
On Thu, Dec 07, 2017 at 02:31:38PM -0800, Junio C Hamano wrote: > If this goes on top as a standalone patch, then the reason why it is > separate from the other users of _default() is not because the way > it uses the null return is special, but because it was written by a > different author, I

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-07 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 07, 2017 at 01:59:39PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote: >> > >> >> Signed-off-by: Junio C Hamano >> >> --- >> > >> > It

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-07 Thread Jeff King
On Thu, Dec 07, 2017 at 01:59:39PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote: > > > >> Signed-off-by: Junio C Hamano > >> --- > > > > It might be worth mentioning why this conversion

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-07 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote: > >> Signed-off-by: Junio C Hamano >> --- > > It might be worth mentioning why this conversion is pulled out from the > others (because its "default" case is "do not touch the

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-07 Thread Jeff King
On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote: > Signed-off-by: Junio C Hamano > --- It might be worth mentioning why this conversion is pulled out from the others (because its "default" case is "do not touch the pointer"). Other than that, it looks good to

Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative

2017-12-07 Thread Jacob Keller
On Thu, Dec 7, 2017 at 9:30 AM, Junio C Hamano wrote: > Signed-off-by: Junio C Hamano > --- > diff.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/diff.c b/diff.c > index cd032c6367..e99ac6ec8a 100644 > --- a/diff.c > +++