On 08.04.13 19:27, Felipe Contreras wrote: > From: Christophe Simonis <christo...@kn.gl> > > Initial patch by Timotheus Pokorra. > > [fc: added tests] > > Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> > --- > contrib/remote-helpers/git-remote-bzr | 15 +++++++++------ > contrib/remote-helpers/test-bzr.sh | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 6 deletions(-) > > + > + export LC_ALL=en_US.UTF-8 > + > + ( > + bzr init bzrrepo && > + cd bzrrepo && > + > + echo test >> "áéíóú" && > + bzr add "áéíóú" &&
Just a whish from my side: bzr under MacOS is not able to handle some unicode characters correctly. (Those we can decompose) https://bugs.launchpad.net/bzr/+bug/172383 I just added a fix on the test-bzr script we have on git.git/next, and the short version is to avoid all code points like áéíóú. The greek stuff is probably OK, but the accents are not. I choose a danish/norwegian "æ", which is not decomposable. (And the non-portable echo -e could be avoided by using printf) /Torsten git diff git.git/next diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh index f4c7768..2150e7c 100755 --- a/contrib/remote-helpers/test-bzr.sh +++ b/contrib/remote-helpers/test-bzr.sh @@ -175,8 +175,8 @@ test_expect_success 'fetch utf-8 filenames' ' bzr init bzrrepo && cd bzrrepo && - echo test >> "áéíóú" && - bzr add "áéíóú" && + echo test >> "æ" && + bzr add "æ" && bzr commit -m utf-8 ) && @@ -185,8 +185,7 @@ test_expect_success 'fetch utf-8 filenames' ' cd gitrepo && git ls-files > ../actual ) && - echo "\"\\303\\241\\303\\251\\303\\255\\303\\263\\303\\272\"" > expected && + echo "\"\\303\\246\"" > expected && test_cmp expected actual ' @@ -209,15 +208,15 @@ test_expect_success 'push utf-8 filenames' ' git clone "bzr::$PWD/bzrrepo" gitrepo && cd gitrepo && - echo test >> "áéíóú" && - git add "áéíóú" && + echo test >> "æ" && + git add "æ" && git commit -m utf-8 && git push ) && (cd bzrrepo && bzr ls > ../actual) && - echo -e "content\náéíóú" > expected && + printf "content\n\303\246\n" > expected && test_cmp expected actual ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
