Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

Liam Beguin writes: > Since this came up, would it be a good thing to add -Wignored-qualifiers > to the DEVELOPER flags? Quite frankly, I am not sure if catching that particular warning violation buys us much. As a return value from a function is never an lvalue, what

Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

Hi Junio, On 27 December 2017 at 20:15, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote: >>> +static const char command_to_char(const enum todo_command command) >>> +{ >>> + if

Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

Duy Nguyen writes: > On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote: >> +static const char command_to_char(const enum todo_command command) >> +{ >> + if (command < TODO_COMMENT && todo_command_info[command].c) >> + return

Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

On Mon, Dec 25, 2017 at 10:39 PM, Liam Beguin wrote: > I'm curious, how did you build to get this error to show? > I tried with the DEVELOPER 'flag' but nothing showed and -Wextra gave > way too much messages... > Did you just add -Wignored-qualifiers to CFLAGS? I have a

Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

Hi Duy, On Mon, 25 Dec 2017 at 07:48 Duy Nguyen wrote: > > On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote: > > +static const char command_to_char(const enum todo_command command) > > +{ > > + if (command < TODO_COMMENT &&

Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin wrote: > +static const char command_to_char(const enum todo_command command) > +{ > + if (command < TODO_COMMENT && todo_command_info[command].c) > + return todo_command_info[command].c; > + return