Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-02-15 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: warning: The behavior of 'git add --update (or -u)' with no path argument from a subdirectory of the tree will change in Git 2.0 and should not be used anymore. There is a logic gap between will

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-02-14 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: We should probably update the documentation/help for git add, but that is entirely a separate topic. The documentation update in 0fa2eb530fb7 (add: warn when -u or -A is used without pathspec, 2013-01-28) says: If no pathspec is given, the current

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-02-14 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: warning: The behavior of 'git add --update (or -u)' with no path argument from a subdirectory of the tree will change in Git 2.0 and should not be used anymore. There is a logic gap between will change and should not be used that is not

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-01-28 Thread Jonathan Nieder
Matthieu Moy wrote: Signed-off-by: Matthieu Moy matthieu@imag.fr Looks good to me. At some point we'll want to have tests for this case, but that's not particularly urgent until it's time for the warning() to turn into a die(). Thanks. Jonathan -- To unsubscribe from this list: send the

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-01-28 Thread Michael J Gruber
Matthieu Moy venit, vidit, dixit 28.01.2013 10:16: Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean', 'git add -u' and 'git add -A'. Since I didn't follow

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-01-28 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: Matthieu Moy venit, vidit, dixit 28.01.2013 10:16: Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean',

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-01-28 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: I think add -u commit vs commit -a you brought up is a good thing to mention, so let's do this. I'm OK with your proposal. Let me know if you want me to resend. The inconsistency of 'git add -u' and 'git add -A' are particularly Nitpick: this

Re: [PATCH v3] add: warn when -u or -A is used without filepattern

2013-01-28 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: I think add -u commit vs commit -a you brought up is a good thing to mention, so let's do this. I'm OK with your proposal. Let me know if you want me to resend. Thanks for a quick response. As you