Re: [PATCH v3] am: invoke perl's strftime in C locale

2013-01-20 Thread Junio C Hamano
"Dmitry V. Levin" writes: > Personally I prefer 2nd edition that is simpler and does the right thing > (not that LC_ALL=C is necessary and sufficient, you neither need to add > things like LANG=C nor can relax it to LC_TIME=C). I guess everybody involved is in agreement, then. Just FYI, "LC_ALL

Re: [PATCH v3] am: invoke perl's strftime in C locale

2013-01-19 Thread Dmitry V. Levin
On Fri, Jan 18, 2013 at 12:36:46PM -0800, Junio C Hamano wrote: > "Dmitry V. Levin" writes: > > > This fixes "hg" patch format support for locales other than C and en_*. > > Before the change, git-am was making "Date:" line from hg changeset > > metadata according to the current locale, and this

Re: [PATCH v3] am: invoke perl's strftime in C locale

2013-01-19 Thread Jeff King
On Fri, Jan 18, 2013 at 12:36:46PM -0800, Junio C Hamano wrote: > > diff --git a/git-am.sh b/git-am.sh > > index c682d34..8677d8c 100755 > > --- a/git-am.sh > > +++ b/git-am.sh > > @@ -334,7 +334,8 @@ split_patches () { > > # Since we cannot guarantee that the commit message is

Re: [PATCH v3] am: invoke perl's strftime in C locale

2013-01-18 Thread Junio C Hamano
"Dmitry V. Levin" writes: > This fixes "hg" patch format support for locales other than C and en_*. > Before the change, git-am was making "Date:" line from hg changeset > metadata according to the current locale, and this line was rejected > later with "invalid date format" diagnostics because l