Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-10 Thread Junio C Hamano
Duy Nguyen writes: > On Sat, Mar 8, 2014 at 1:27 AM, Junio C Hamano wrote: On the receive-pack side, the comment at the bottom of preprare_shallow_update() makes it clear that, if we wanted to use hooks, we cannot avoid having the proposed new shallow-file in a temporary file

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-07 Thread Duy Nguyen
On Sat, Mar 8, 2014 at 1:27 AM, Junio C Hamano wrote: >>> On the receive-pack side, the comment at the bottom of >>> preprare_shallow_update() makes it clear that, if we wanted to use >>> hooks, we cannot avoid having the proposed new shallow-file in a >>> temporary file, which is unfortunate. Do

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-07 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Mar 6, 2014 at 3:49 PM, Nguyễn Thái Ngọc Duy > wrote: >> diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh >> index 3ae9092..a980574 100755 >> --- a/t/t5537-fetch-shallow.sh >> +++ b/t/t5537-fetch-shallow.sh >> @@ -173,4 +173,17 @@ EOF >> ) >>

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-07 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Mar 7, 2014 at 1:37 AM, Junio C Hamano wrote: >> I like what I see in this patch, but I wonder if we can essentially >> revert that "temporary shallow file" patch and replace it with the >> same (or a similar) mechanism uniformly? > > Using --shallow-file is uniform.

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-06 Thread Duy Nguyen
On Thu, Mar 6, 2014 at 3:49 PM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh > index 3ae9092..a980574 100755 > --- a/t/t5537-fetch-shallow.sh > +++ b/t/t5537-fetch-shallow.sh > @@ -173,4 +173,17 @@ EOF > ) > ' > > +test_expect_success POSI

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-06 Thread Duy Nguyen
On Fri, Mar 7, 2014 at 1:37 AM, Junio C Hamano wrote: > I like what I see in this patch, but I wonder if we can essentially > revert that "temporary shallow file" patch and replace it with the > same (or a similar) mechanism uniformly? Using --shallow-file is uniform.The only downside is temporar

Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

2014-03-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > From: Duy Nguyen > > Before cdab485 (upload-pack: delegate rev walking in shallow fetch to > pack-objects - 2013-08-16) upload-pack does not write to the source > repository. cdab485 starts to write $GIT_DIR/shallow_XX if it's a > shallow fetch, so the source