Re: [PATCH v3 0/6] git send-email suppress-cc=self fixes

2013-06-04 Thread Junio C Hamano
Michael S. Tsirkin m...@redhat.com writes:

 This includes bugfixes related to handling of --suppress-cc=self
 flag. Tests are also included.

Hmph, flipped the patches without test-applying first?

2/6 adds two lines to test_suppress_self_quoted helper function, but
that is introduced only at 4/6.


 Changes from v2:
   - add a new test, split patches differently add code comments
to address comments by Junio
   - rename example addresses in tests from redhat.com to example.com
 Changes from v1:
 - tweak coding style in tests to address comments by Junio


 Michael S. Tsirkin (6):
   send-email: fix suppress-cc=self on cccmd
   t/send-email: test suppress-cc=self on cccmd
   send-email: make --suppress-cc=self sanitize input
   t/send-email: add test with quoted sender
   t/send-email: test suppress-cc=self with non-ascii
   test-send-email: test for pre-sanitized self name

  git-send-email.perl   | 23 +++
  t/t9001-send-email.sh | 34 +-
  2 files changed, 48 insertions(+), 9 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 0/6] git send-email suppress-cc=self fixes

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 10:40:51AM -0700, Junio C Hamano wrote:
 Michael S. Tsirkin m...@redhat.com writes:
 
  This includes bugfixes related to handling of --suppress-cc=self
  flag. Tests are also included.
 
 Hmph, flipped the patches without test-applying first?

No, I generated the patches with git format-patch,
then processed with git send-email.

 2/6 adds two lines to test_suppress_self_quoted helper function, but
 that is introduced only at 4/6.

I don't see it
All I see in 2/6 is this:

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index e1a7f3e..f81e5f5 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -204,13 +204,15 @@ test_suppress_self_unquoted () {

unquoted-$3

+   cccmd--$1 $2
+
Cc: $1 $2
Signed-off-by: $1 $2
EOF
 }

 test_expect_success $PREREQ 'self name is suppressed' 
-   test_suppress_self_unquoted 'A U Thor' 'aut...@redhat.com' \
+   test_suppress_self_unquoted 'A U Thor' 'aut...@example.com' \
'self_name_suppressed'
 

where's test_suppress_self_quoted here?


 
  Changes from v2:
  - add a new test, split patches differently add code comments
   to address comments by Junio
  - rename example addresses in tests from redhat.com to example.com
  Changes from v1:
  - tweak coding style in tests to address comments by Junio
 
 
  Michael S. Tsirkin (6):
send-email: fix suppress-cc=self on cccmd
t/send-email: test suppress-cc=self on cccmd
send-email: make --suppress-cc=self sanitize input
t/send-email: add test with quoted sender
t/send-email: test suppress-cc=self with non-ascii
test-send-email: test for pre-sanitized self name
 
   git-send-email.perl   | 23 +++
   t/t9001-send-email.sh | 34 +-
   2 files changed, 48 insertions(+), 9 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html