Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-08 Thread Liam Beguin
Hi, On Mon, 2017-05-08 at 09:27 +0900, Junio C Hamano wrote: > Liam Beguin writes: > > > Sorry for the delay, I don't mind switching to C but it would probably > > be easier to see if the scripted version gets approved first. > > If it does, I could then get started on the

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-07 Thread Junio C Hamano
Liam Beguin writes: > Sorry for the delay, I don't mind switching to C but it would probably > be easier to see if the scripted version gets approved first. > If it does, I could then get started on the C implementation. > If you prefer I could also forget about the

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-07 Thread Liam Beguin
Hi Junio, On Wed, 2017-05-03 at 22:04 -0700, Junio C Hamano wrote: > Johannes Schindelin writes: > > > > If 'git-rebase--interactive.sh' is bound to be replaced, I could > > > just shrink this to the Documentation cleanup (patches 4 and 5) > > > and rework the rest

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-03 Thread Junio C Hamano
Johannes Schindelin writes: >> If 'git-rebase--interactive.sh' is bound to be replaced, I could >> just shrink this to the Documentation cleanup (patches 4 and 5) >> and rework the rest on top of your new implementation. > > I kind of hoped that Junio would chime in

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-03 Thread Johannes Schindelin
Hi Liam, On Tue, 2 May 2017, Liam Beguin wrote: > On Tue, 2017-05-02 at 17:48 +0200, Johannes Schindelin wrote: > > > I offered a couple of comments, my biggest one probably being that > > this patch series is crossing paths with my patch series that tries to > > move more functionality out of

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-02 Thread Liam Beguin
Hi Johannes, On Tue, 2017-05-02 at 17:48 +0200, Johannes Schindelin wrote: > Hi Liam, > > On Tue, 2 May 2017, Liam Beguin wrote: > > > Add the 'rebase.abbreviateCommands' configuration option to allow `git > > rebase -i` to default to the single-letter command-names in the todo > > list. > >

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-02 Thread Johannes Schindelin
Hi Liam, On Tue, 2 May 2017, Liam Beguin wrote: > Add the 'rebase.abbreviateCommands' configuration option to allow `git > rebase -i` to default to the single-letter command-names in the todo > list. > > Using single-letter command-names can present two benefits. First, it > makes it easier to

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-02 Thread Johannes Schindelin
Hi, On Tue, 2 May 2017, Ævar Arnfjörð Bjarmason wrote: > I locally rebased this into just 3 patches, i.e. in this sequence: > > - Documentation: move rebase.* config variables to a separate > rebase-config.txt > - Documentation: use preferred name for the 'todo list' script > - *all the rest

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

2017-05-02 Thread Ævar Arnfjörð Bjarmason
On Tue, May 2, 2017 at 6:00 AM, Liam Beguin wrote: > Add the 'rebase.abbreviateCommands' configuration option to allow > `git rebase -i` to default to the single-letter command-names in > the todo list. > > Using single-letter command-names can present two benefits. > First,