Re: [PATCH v3 03/31] Add parse_pathspec() that converts cmdline args to struct pathspec

2013-01-13 Thread Martin von Zweigbergk 
On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
 +static void parse_pathspec(struct pathspec *pathspec,
 +  unsigned magic_mask, unsigned flags,
 +  const char *prefix, const char **argv)
 +{
 +   struct pathspec_item *item;
 +   const char *entry = *argv;
 ...
 +   for (i = 0; i  n; i++) {
 +   const char *arg = argv[i];

Nit: *argv was assigned to entry above. Reassign that variable instead?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 03/31] Add parse_pathspec() that converts cmdline args to struct pathspec

2013-01-13 Thread Duy Nguyen 
On Mon, Jan 14, 2013 at 7:05 AM, Martin von Zweigbergk
martinv...@gmail.com wrote:
 On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com 
 wrote:
 +static void parse_pathspec(struct pathspec *pathspec,
 +  unsigned magic_mask, unsigned flags,
 +  const char *prefix, const char **argv)
 +{
 +   struct pathspec_item *item;
 +   const char *entry = *argv;
 ...
 +   for (i = 0; i  n; i++) {
 +   const char *arg = argv[i];

 Nit: *argv was assigned to entry above. Reassign that variable instead?

Yeah. Thanks for catching.
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html