Re: [PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-05 Thread Jeff King
On Wed, Apr 04, 2018 at 06:53:04PM -0700, Taylor Blau wrote: > > I understand that you're doing this to avoid complaining about "--int > > --type=int", but exactly how that case is supported should be an > > implementation detail; it doesn't need to bleed into the UI as an > > unnecessary and not-

Re: [PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Taylor Blau
On Wed, Apr 04, 2018 at 03:57:12AM -0400, Eric Sunshine wrote: > On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > > [...] > > In fact, `git config` will not accept multiple type specifiers at a > > time, as indicated by: > > > > $ git config --int --bool some.section > > error: only one ty

Re: [PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Eric Sunshine
On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > [...] > In fact, `git config` will not accept multiple type specifiers at a > time, as indicated by: > > $ git config --int --bool some.section > error: only one type at a time. > > This patch uses `OPT_SET_INT` to prefer the _last_ mentione