Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh

2012-07-24 Thread Stefano Lattarini 
On 07/24/2012 08:59 AM, Jiang Xin wrote:
 Since we have additional shell wrappers (gettextln and eval_gettextln)
 for gettext, we need to take into account these wrappers when run

s/when run/when running/ or s/when we run/.

Sorry for not spotting that in my first review!

 'make pot' to extract messages from shell scripts.
 

Regards,
  Stefano
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh

2012-07-24 Thread Jonathan Nieder 
Jiang Xin wrote:

 Since we have additional shell wrappers (gettextln and eval_gettextln)
 for gettext, we need to take into account these wrappers when run
 'make pot' to extract messages from shell scripts.

Yes, thanks for fixing it.

As Stefano mentioned, s/run/running/ would make the above clearer.

With or without that change,
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html