Re: [PATCH v3 11/21] pack-objects: use bitmaps when packing objects

2013-12-21 Thread Jeff King
On Sat, Dec 07, 2013 at 04:47:20PM +0100, Thomas Rast wrote: +static off_t write_reused_pack(struct sha1file *f) +{ + uint8_t buffer[8192]; We usually just call this 'unsigned char'. I can see why this would be more portable, but git would already fall apart badly on an architecture

Re: [PATCH v3 11/21] pack-objects: use bitmaps when packing objects

2013-12-07 Thread Thomas Rast
This week's nits... I found this harder to read than the previous patch, but I think it's mostly because the existing code is already a bit tangled. I think the second item below is worth fixing, though. Jeff King p...@peff.net writes: +static off_t write_reused_pack(struct sha1file *f) +{