Johannes Schindelin writes:
>> I think my puzzlement comes from here. What makes it OK for "am" to
>> expect the contents of author-script file to be quoted but it is not
>> OK to expect the same here? What makes it not quoted for _this_
>> reader, in other words?
>
> The `git am` command is in
Hi Junio,
On Wed, 12 Oct 2016, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> >> Hmph, didn't we recently add parse_key_value_squoted() to build
> >> read_author_script() in builtin/am.c on top of it, so that this
> >> piece of code can also take advantage of and share the parser?
> >
Johannes Schindelin writes:
>> Hmph, didn't we recently add parse_key_value_squoted() to build
>> read_author_script() in builtin/am.c on top of it, so that this
>> piece of code can also take advantage of and share the parser?
>
> I already pointed out that the author-script file may *not* be qu
Hi Junio,
On Tue, 11 Oct 2016, Junio C Hamano wrote:
> > @@ -370,19 +383,79 @@ static int is_index_unchanged(void)
> > }
> >
> > /*
> > + * Read the author-script file into an environment block, ready for use in
> > + * run_command(), that can be free()d afterwards.
> > + */
> > +static char
> @@ -370,19 +383,79 @@ static int is_index_unchanged(void)
> }
>
> /*
> + * Read the author-script file into an environment block, ready for use in
> + * run_command(), that can be free()d afterwards.
> + */
> +static char **read_author_script(void)
> +{
> + struct strbuf script = STRBUF_I
5 matches
Mail list logo