Re: [PATCH v3 2/3] config.c: introduce 'git_config_color' to parse ANSI colors

2018-04-04 Thread Taylor Blau 
On Fri, Mar 30, 2018 at 04:26:09PM -0400, Eric Sunshine wrote:
> On Wed, Mar 28, 2018 at 9:16 PM, Taylor Blau  wrote:
> > In preparation for adding `--color` to the `git-config(1)` builtin,
> > let's introduce a color parsing utility, `git_config_color` in a similar
> > fashion to `git_config_`.
>
> Did you mean s/--color/--type=color/ ?

I did; thanks for pointing this out. I have fixed this to mention
"--type=color" in the subsequent re-roll.

Thanks,
Taylor

Re: [PATCH v3 2/3] config.c: introduce 'git_config_color' to parse ANSI colors

2018-03-30 Thread Eric Sunshine 
On Wed, Mar 28, 2018 at 9:16 PM, Taylor Blau  wrote:
> In preparation for adding `--color` to the `git-config(1)` builtin,
> let's introduce a color parsing utility, `git_config_color` in a similar
> fashion to `git_config_`.

Did you mean s/--color/--type=color/ ?

> Signed-off-by: Taylor Blau