Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts

Оля Тележная writes: >>> - else if (deref) >>> + } else if (!strcmp(name, "objectsize:disk")) { >>> + if (cat_file_info.is_cat_file) { >>> + v->value = cat_file_info.disk_size; >>> + v->s = xstrfm

Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts

2018-02-15 8:56 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> cat-file options are now filled by general logic. > > Yay. > > One puzzling thing: > >> diff --git a/ref-filter.c b/ref-filter.c >> index 8d104b567eb7c..5781416cf9126 100644 >> --- a/ref-fi

Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts

On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > cat-file options are now filled by general logic. Yay. One puzzling thing: > diff --git a/ref-filter.c b/ref-filter.c > index 8d104b567eb7c..5781416cf9126 100644 > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -824,8 +824,12 @@ s