Re: [PATCH v3 21/20] convert: drop invalid comment for subprocess_entry

2019-10-07 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > "struct hashmap_entry" inside "struct subprocess_entry" > > no longer needs to be the first member of any struct, > > so the old comment is no longer true. > > Hmm, is that true? > > struct cmd2process { > struct subprocess_entry subprocess

Re: [PATCH v3 21/20] convert: drop invalid comment for subprocess_entry

2019-10-07 Thread Junio C Hamano
Eric Wong writes: > "struct hashmap_entry" inside "struct subprocess_entry" > no longer needs to be the first member of any struct, > so the old comment is no longer true. Hmm, is that true? struct cmd2process { struct subprocess_entry subprocess; unsigned int supported_capabili