Re: [PATCH v3 29/42] completion: use __gitcomp_builtin in _git_notes

2018-02-23 Thread Duy Nguyen
On Fri, Feb 23, 2018 at 5:33 PM, Duy Nguyen wrote: > On Wed, Feb 14, 2018 at 9:29 PM, SZEDER Gábor wrote: >> And we could even go one step further: >> >> *,--*) >> __gitcomp_builtin notes_$subcommand >> ;; >> >> This would have the

Re: [PATCH v3 29/42] completion: use __gitcomp_builtin in _git_notes

2018-02-23 Thread Duy Nguyen
On Wed, Feb 14, 2018 at 10:15 PM, SZEDER Gábor wrote: > On Fri, Feb 9, 2018 at 12:02 PM, Nguyễn Thái Ngọc Duy > wrote: > >> diff --git a/contrib/completion/git-completion.bash >> b/contrib/completion/git-completion.bash >> index c7b8b37f19..60127daebf

Re: [PATCH v3 29/42] completion: use __gitcomp_builtin in _git_notes

2018-02-23 Thread Duy Nguyen
On Wed, Feb 14, 2018 at 9:29 PM, SZEDER Gábor wrote: > On Fri, Feb 9, 2018 at 12:02 PM, Nguyễn Thái Ngọc Duy > wrote: > >> diff --git a/contrib/completion/git-completion.bash >> b/contrib/completion/git-completion.bash >> index c7b8b37f19..60127daebf

Re: [PATCH v3 29/42] completion: use __gitcomp_builtin in _git_notes

2018-02-14 Thread SZEDER Gábor
On Fri, Feb 9, 2018 at 12:02 PM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/contrib/completion/git-completion.bash > b/contrib/completion/git-completion.bash > index c7b8b37f19..60127daebf 100644 > --- a/contrib/completion/git-completion.bash > +++

Re: [PATCH v3 29/42] completion: use __gitcomp_builtin in _git_notes

2018-02-14 Thread SZEDER Gábor
On Fri, Feb 9, 2018 at 12:02 PM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/contrib/completion/git-completion.bash > b/contrib/completion/git-completion.bash > index c7b8b37f19..60127daebf 100644 > --- a/contrib/completion/git-completion.bash > +++