Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-09-03 Thread Jens Lehmann
Am 29.08.2013 21:54, schrieb Jens Lehmann: > Am 29.08.2013 15:05, schrieb Matthieu Moy: >> The --for-status option was an undocumented option used only by >> wt-status.c, which inserted a header and commented out the output. We can >> achieve the same result within wt-status.c, without polluting th

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-09-01 Thread Jens Lehmann
Am 31.08.2013 19:08, schrieb brian m. carlson: > On Fri, Aug 30, 2013 at 10:08:53PM +0200, Jens Lehmann wrote: >> Am 30.08.2013 21:51, schrieb Jens Lehmann: >>> Am 30.08.2013 21:40, schrieb Jens Lehmann: Am 29.08.2013 23:23, schrieb Matthieu Moy: > Jens Lehmann writes: > >> Am 29.

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-31 Thread brian m. carlson
On Fri, Aug 30, 2013 at 10:08:53PM +0200, Jens Lehmann wrote: > Am 30.08.2013 21:51, schrieb Jens Lehmann: > > Am 30.08.2013 21:40, schrieb Jens Lehmann: > >> Am 29.08.2013 23:23, schrieb Matthieu Moy: > >>> Jens Lehmann writes: > >>> > Am 29.08.2013 15:05, schrieb Matthieu Moy: > >>> Because

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-30 Thread Jens Lehmann
Am 29.08.2013 23:23, schrieb Matthieu Moy: > Jens Lehmann writes: > >> Am 29.08.2013 15:05, schrieb Matthieu Moy: >>> The --for-status option was an undocumented option used only by >>> wt-status.c, which inserted a header and commented out the output. We can >>> achieve the same result within wt

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-30 Thread Jens Lehmann
Am 30.08.2013 21:40, schrieb Jens Lehmann: > Am 29.08.2013 23:23, schrieb Matthieu Moy: >> Jens Lehmann writes: >> >>> Am 29.08.2013 15:05, schrieb Matthieu Moy: The --for-status option was an undocumented option used only by wt-status.c, which inserted a header and commented out the out

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-30 Thread Jens Lehmann
Am 30.08.2013 21:51, schrieb Jens Lehmann: > Am 30.08.2013 21:40, schrieb Jens Lehmann: >> Am 29.08.2013 23:23, schrieb Matthieu Moy: >>> Jens Lehmann writes: >>> Am 29.08.2013 15:05, schrieb Matthieu Moy: > The --for-status option was an undocumented option used only by > wt-status.c

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-29 Thread Matthieu Moy
Jens Lehmann writes: > Am 29.08.2013 15:05, schrieb Matthieu Moy: >> The --for-status option was an undocumented option used only by >> wt-status.c, which inserted a header and commented out the output. We can >> achieve the same result within wt-status.c, without polluting the >> submodule comma

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-29 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> +/* prepend header, only if there's an actual output */ >> +if (len) { >> +if (uncommitted) >> +strbuf_addstr(&summary, _("Submodules changed but not >> updated:")); >> +else >> +

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-29 Thread Junio C Hamano
Matthieu Moy writes: > + /* prepend header, only if there's an actual output */ > + if (len) { > + if (uncommitted) > + strbuf_addstr(&summary, _("Submodules changed but not > updated:")); > + else > + strbuf_addstr(&summary

Re: [PATCH v3 3/4] get rid of "git submodule summary --for-status"

2013-08-29 Thread Jens Lehmann
Am 29.08.2013 15:05, schrieb Matthieu Moy: > The --for-status option was an undocumented option used only by > wt-status.c, which inserted a header and commented out the output. We can > achieve the same result within wt-status.c, without polluting the > submodule command-line options. > > This wi