Re: [PATCH v3 5/7] convert_to_git(): safe_crlf/checksafe becomes int conv_flags

On Mon, Jan 08, 2018 at 11:47:20PM +0100, Lars Schneider wrote: > > > On 08 Jan 2018, at 22:28, Junio C Hamano wrote: > > > > lars.schnei...@autodesk.com writes: > > > >> diff --git a/sha1_file.c b/sha1_file.c > >> index afe4b90f6e..dcb02e9ffd 100644 > >> --- a/sha1_file.c >

Re: [PATCH v3 5/7] convert_to_git(): safe_crlf/checksafe becomes int conv_flags

Lars Schneider writes: > Nice catch. I'll fix that in the next iteration. > > Is it OK if I send the next iteration soon or would you prefer > it if I wait until after 2.16 release? > > Plus, is it ok to keep the base of the series or would you prefer > it if I rebase

Re: [PATCH v3 5/7] convert_to_git(): safe_crlf/checksafe becomes int conv_flags

> On 08 Jan 2018, at 22:28, Junio C Hamano wrote: > > lars.schnei...@autodesk.com writes: > >> diff --git a/sha1_file.c b/sha1_file.c >> index afe4b90f6e..dcb02e9ffd 100644 >> --- a/sha1_file.c >> +++ b/sha1_file.c >> @@ -75,14 +75,14 @@ static struct cached_object

Re: [PATCH v3 5/7] convert_to_git(): safe_crlf/checksafe becomes int conv_flags

lars.schnei...@autodesk.com writes: > diff --git a/sha1_file.c b/sha1_file.c > index afe4b90f6e..dcb02e9ffd 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -75,14 +75,14 @@ static struct cached_object *find_cached_object(const > unsigned char *sha1) > } > > > -static enum safe_crlf