Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
Junio C Hamano gits...@pobox.com writes:
Jonathan Nieder jrnie...@gmail.com writes:
Before this patch, it says
The --binary option has been a no-op for a long time, and ...
After the patch, it says
The -b option has been a no-op for a long time, and ...
Intentional? That may be a good change or a bad one (I haven't
thought clearly about it), but it seems at least worth mentioning.
Cc-ing Thomas in case he has advice.
If we really care we could printf $1, but I think we usually do
The -b/--binary option has been...
in a case like this, especially in codepaths that no longer has an
easy access to $1 after parsing the command line but knows that
either one of them is given from the parse result, and that would be
an appropriate solution for this particular one as well.
Yes. The original plan was to free up -b, but since we don't need
--binary any more either, it's better if we can get rid of it the same
way.
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
Hi, Jiang Xin wrote: Mark additional 3 strings for translation, and reduce one indentation level for one gettextln clause introduced in commit de88c1c. The above description doesn't mention: [...] @@ -387,8 +386,8 @@ do -i|--interactive) interactive=t ;; -b|--binary) - echo 2 The $1 option has been a no-op for long time, and - echo 2 it will be removed. Please do not use it anymore. + echo 2 $(gettext The -b option has been a no-op for long time, and +it will be removed. Please do not use it anymore.) ... that this changes the message when the --binary option is passed. Before this patch, it says The --binary option has been a no-op for a long time, and ... After the patch, it says The -b option has been a no-op for a long time, and ... Intentional? That may be a good change or a bad one (I haven't thought clearly about it), but it seems at least worth mentioning. Cc-ing Thomas in case he has advice. Thanks, Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
Jonathan Nieder jrnie...@gmail.com writes: -b|--binary) -echo 2 The $1 option has been a no-op for long time, and -echo 2 it will be removed. Please do not use it anymore. +echo 2 $(gettext The -b option has been a no-op for long time, and +it will be removed. Please do not use it anymore.) ... that this changes the message when the --binary option is passed. Before this patch, it says The --binary option has been a no-op for a long time, and ... After the patch, it says The -b option has been a no-op for a long time, and ... Intentional? That may be a good change or a bad one (I haven't thought clearly about it), but it seems at least worth mentioning. Cc-ing Thomas in case he has advice. If we really care we could printf $1, but I think we usually do The -b/--binary option has been... in a case like this, especially in codepaths that no longer has an easy access to $1 after parsing the command line but knows that either one of them is given from the parse result, and that would be an appropriate solution for this particular one as well. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
2012/7/25 Jonathan Nieder jrnie...@gmail.com: -b|--binary) - echo 2 The $1 option has been a no-op for long time, and - echo 2 it will be removed. Please do not use it anymore. + echo 2 $(gettext The -b option has been a no-op for long time, and +it will be removed. Please do not use it anymore.) ... that this changes the message when the --binary option is passed. Before this patch, it says The --binary option has been a no-op for a long time, and ... After the patch, it says The -b option has been a no-op for a long time, and ... Intentional? That may be a good change or a bad one (I haven't thought clearly about it), but it seems at least worth mentioning. Cc-ing Thomas in case he has advice. It's intentional. * First, if a variable in the message, we could not use gettext, for the variable will be expanded (evaluated) and never match the entry in po file. * Second, if there is a positional parameter ($1, $2,...) in the message, we could not use eval_gettext either. Because eval_gettext may be a wapper for gettext, and the positional parameter would loose it's original context. -- Jiang Xin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
