Re: [PATCH v3 6/6] diff: shortcut for diff'ing two binary SHA-1 objects

2014-08-15 Thread Duy Nguyen
On Fri, Aug 15, 2014 at 12:00 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/t/t1050-large.sh b/t/t1050-large.sh >> index 711f22c..b294963 100755 >> --- a/t/t1050-large.sh >> +++ b/t/t1050-large.sh >> @@ -116,6 +116,14 @@ test_expect_success 'diff --stat' ' >> g

Re: [PATCH v3 6/6] diff: shortcut for diff'ing two binary SHA-1 objects

2014-08-14 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > If we are given two SHA-1 and asked to determine if they are different > (but not _what_ differences), we know right away by comparing SHA-1. > > A side effect of this patch is, because large files are marked binary, > diff-tree will not need to unpack them. 'diff-

Re: [PATCH v3 6/6] diff: shortcut for diff'ing two binary SHA-1 objects

2014-08-14 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/t/t1050-large.sh b/t/t1050-large.sh > index 711f22c..b294963 100755 > --- a/t/t1050-large.sh > +++ b/t/t1050-large.sh > @@ -116,6 +116,14 @@ test_expect_success 'diff --stat' ' > git diff --stat HEAD^ HEAD > ' > > +test_expect_success 'diff' '