Re: [PATCH v4] submodule: add 'deinit' command

2013-03-18 Thread Jens Lehmann
Am 12.03.2013 17:22, schrieb Junio C Hamano: Phil Hord phil.h...@gmail.com writes: I think this would be clearer if 'git deinit' said rm 'submodule/*' or maybe Removed workdir for 'submodule' Is it just me? The latter may probably be better. Hmm, it doesn't really remove

Re: [PATCH v4] submodule: add 'deinit' command

2013-03-18 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Am 12.03.2013 17:22, schrieb Junio C Hamano: Phil Hord phil.h...@gmail.com writes: I think this would be clearer if 'git deinit' said rm 'submodule/*' or maybe Removed workdir for 'submodule' Is it just me? The latter may probably

Re: [PATCH v4] submodule: add 'deinit' command

2013-03-12 Thread Phil Hord
On Wed, Feb 6, 2013 at 4:11 PM, Jens Lehmann jens.lehm...@web.de wrote: With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But currently there is no easy way he could tell git he

Re: [PATCH v4] submodule: add 'deinit' command

2013-03-12 Thread Junio C Hamano
Phil Hord phil.h...@gmail.com writes: I think this would be clearer if 'git deinit' said rm 'submodule/*' or maybe Removed workdir for 'submodule' Is it just me? The latter may probably be better. After cloning the superproject, you show interest in individual submodules by

Re: [PATCH v4] submodule: add 'deinit' command

2013-02-13 Thread Jens Lehmann
Am 12.02.2013 18:11, schrieb Phil Hord: On Wed, Feb 6, 2013 at 4:11 PM, Jens Lehmann jens.lehm...@web.de wrote: + die_if_unmatched $mode + name=$(module_name $sm_path) || exit + url=$(git config submodule.$name.url) + if test -z $url +

Re: [PATCH v4] submodule: add 'deinit' command

2013-02-13 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Junio, this looks like a we have v5 as soon as we decide what to do with the not initialized messages when '.' is used, right? OK. I myself do not deeply care if we end up special casing . or not; I'll leave it up to you and other submodule folks.

Re: [PATCH v4] submodule: add 'deinit' command

2013-02-12 Thread Phil Hord
I haven't tried it yet, but I have some comments. On Wed, Feb 6, 2013 at 4:11 PM, Jens Lehmann jens.lehm...@web.de wrote: With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But

Re: [PATCH v4] submodule: add 'deinit' command

2013-02-12 Thread Junio C Hamano
Phil Hord phil.h...@gmail.com writes: + if test $# = 0 + then + die $(eval_gettext Use '.' if you really want to deinitialize all submodules) + fi + + module_list $@ | + while read mode sha1 stage sm_path + do +