Re: [PATCH v4 00/12] Wildmatch v4

2012-10-12 Thread Torsten Bögershausen
On 11.10.12 13:56, Nguyen Thai Ngoc Duy wrote: On Thu, Oct 11, 2012 at 11:33 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Really small updates. I did not want to resend it this soon but this may fix the

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-12 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: On 11.10.12 13:56, Nguyen Thai Ngoc Duy wrote: On Thu, Oct 11, 2012 at 11:33 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Really small updates. I did not want

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-12 Thread Torsten Bögershausen
On 10/12/2012 07:05 PM, Junio C Hamano wrote: Some problems even here (Mac OS) commit 2aeb6d4d7884f4c4425 not ok 61 - wildmatch 0 0 \ \ not ok 62 - wildmatch 0 0 /\ */\ not ok 69 - wildmatch 1 1 [ab] [[:]ab] not ok 71 - wildmatch 1 1 [ab] [[:digit]ab] not ok 80 - wildmatch 1 0 1

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-12 Thread Nguyen Thai Ngoc Duy
On Fri, Oct 12, 2012 at 10:05:06AM -0700, Junio C Hamano wrote: Nguyen, how about updating the match () shell function in 3070 so that it not just says not-ok, but indicates what failed (wildmatch failed, or wildmatch passed but fnmatch failed), at least when the test is run as ./t3070-*.sh -v

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-11 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: On Thu, Oct 11, 2012 at 11:33 AM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Really small updates. I did not want to resend it this soon but this may fix the

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-11 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: This probably is due to this part of the output: ok 72 - wildmatch 1 1 [ab] [\[:]ab] ok 73 - wildmatch 1 1 ?a?b \??\?b ok 74 - wildmatch 1 1 abc ^G^Hok 75 - wildmatch 0 0 foo ok 76 - wildmatch 1 0 foo/bar/baz/to **/t[o] ok 77 -

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-11 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Ahh, it must be this bits from t/test-lib.sh t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git i/t/test-lib.sh w/t/test-lib.sh index 514282c..489bc80 100644 --- i/t/test-lib.sh +++ w/t/test-lib.sh @@ -230,7 +230,7 @@

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Really small updates. I did not want to resend it this soon but this may fix the compile errors for Junio. Thanks; queued and pushed out on 'pu'. Comments later. -- To unsubscribe from this list: send the line unsubscribe git in the body of a

Re: [PATCH v4 00/12] Wildmatch v4

2012-10-10 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Really small updates. I did not want to resend it this soon but this may fix the compile errors for Junio. t3070 seems to break TAP, *** prove *** t3070-wildmatch.sh .. Failed 1/151 subtests