Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-05 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 02.11.2012 17:09: On Fri, Nov 2, 2012 at 12:03 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Andreas Ericsson venit, vidit, dixit 02.11.2012 10:38: On 11/01/2012 02:46 PM, René Scharfe wrote: Also, and I'm sure you didn't know that, Jedem das

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-05 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 02.11.2012 19:01: On Fri, Nov 2, 2012 at 5:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 2, 2012 at 3:48 PM, Jeff King p...@peff.net wrote: On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote: Turns out msysgit's

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-05 Thread Felipe Contreras
On Mon, Nov 5, 2012 at 10:25 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Felipe Contreras venit, vidit, dixit 02.11.2012 17:09: On Fri, Nov 2, 2012 at 12:03 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Andreas Ericsson venit, vidit, dixit 02.11.2012 10:38: On 11/01/2012

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-05 Thread Felipe Contreras
On Mon, Nov 5, 2012 at 3:13 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Felipe Contreras venit, vidit, dixit 02.11.2012 19:01: I talked with some people in #mercurial, and apparently there is a concept of a 'changelog' that is supposed to store these changes, but since the format

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-03 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 8:20 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 2, 2012 at 7:39 PM, Felipe Contreras felipe.contre...@gmail.com wrote: As a rule, I don't see much value in writing a framework that works only for one case, that smells more like over-engineering.

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Andreas Ericsson
On 11/01/2012 02:46 PM, René Scharfe wrote: Also, and I'm sure you didn't know that, Jedem das Seine (to each his own) was the slogan of the Buchenwald concentration camp. For that reason some (including me) hear the unspoken cynical half-sentence and some people just have to be sent to the

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Michael J Gruber
Andreas Ericsson venit, vidit, dixit 02.11.2012 10:38: On 11/01/2012 02:46 PM, René Scharfe wrote: Also, and I'm sure you didn't know that, Jedem das Seine (to each his own) was the slogan of the Buchenwald concentration camp. For that reason some (including me) hear the unspoken cynical

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Jeff King
On Wed, Oct 31, 2012 at 05:11:39PM +0100, Felipe Contreras wrote: As a patch submitter, you (generic you) want the attention of others as reviewers. It's in your own (again generic you) interest not to put them off, in the same way as it's up to the submitter to argue why a patch is

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Jeff King
On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote: Turns out msysgit's remote-hg is not exporting the whole repository, that's why it's faster =/ It seems the reason is that it would only export to the point where the branch is checked out. After updating the to the tip I

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 12:03 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Andreas Ericsson venit, vidit, dixit 02.11.2012 10:38: On 11/01/2012 02:46 PM, René Scharfe wrote: Also, and I'm sure you didn't know that, Jedem das Seine (to each his own) was the slogan of the Buchenwald

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 3:48 PM, Jeff King p...@peff.net wrote: On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote: Turns out msysgit's remote-hg is not exporting the whole repository, that's why it's faster =/ It seems the reason is that it would only export to the point

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 5:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 2, 2012 at 3:48 PM, Jeff King p...@peff.net wrote: On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote: Turns out msysgit's remote-hg is not exporting the whole repository, that's why

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 3:46 PM, Jeff King p...@peff.net wrote: On Wed, Oct 31, 2012 at 05:11:39PM +0100, Felipe Contreras wrote: As a patch submitter, you (generic you) want the attention of others as reviewers. It's in your own (again generic you) interest not to put them off, in the

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 7:39 PM, Felipe Contreras felipe.contre...@gmail.com wrote: As a rule, I don't see much value in writing a framework that works only for one case, that smells more like over-engineering. If we had two cases (hg and bzr), then we might be able to know with a modicum of

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Thomas Adam
On 2 November 2012 18:39, Felipe Contreras felipe.contre...@gmail.com wrote: I disagree. The open source process works not by making favors to each other, but by everyone sharing and improving the code, by *collaborating*. I review your code if you review mine, or if you by me a bear in the

Re: [PATCH v4 00/13] New remote-hg helper

2012-11-02 Thread Felipe Contreras
On Sat, Nov 3, 2012 at 12:18 AM, Thomas Adam tho...@xteddy.org wrote: On 2 November 2012 18:39, Felipe Contreras felipe.contre...@gmail.com wrote: I disagree. The open source process works not by making favors to each other, but by everyone sharing and improving the code, by *collaborating*. I

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread René Scharfe
Am 01.11.2012 03:58, schrieb Felipe Contreras: On Thu, Nov 1, 2012 at 2:32 AM, Junio C Hamano gits...@pobox.com wrote: Johannes Schindelin johannes.schinde...@gmx.de wrote: On Wed, 31 Oct 2012, Felipe Contreras wrote: It doesn't get any more obvious than that. But to each his own. In my

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Tomas Carnecky
On Thu, Nov 1, 2012 at 1:46 PM, René Scharfe rene.scha...@lsrfire.ath.cx wrote: Also, and I'm sure you didn't know that, Jedem das Seine (to each his own) was the slogan of the Buchenwald concentration camp. For that reason some (including me) hear the unspoken cynical half-sentence and some

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Martin Langhoff
On Thu, Nov 1, 2012 at 9:46 AM, René Scharfe rene.scha...@lsrfire.ath.cx wrote: You probably didn't intend it, but your sentences at the top can be read more like: This is a logical consequence. If you don't understand that, your mental capabilities must be lacking.. That's obviously (ha!) a

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:46 PM, René Scharfe rene.scha...@lsrfire.ath.cx wrote: Am 01.11.2012 03:58, schrieb Felipe Contreras: On Thu, Nov 1, 2012 at 2:32 AM, Junio C Hamano gits...@pobox.com wrote: Johannes Schindelin johannes.schinde...@gmx.de wrote: On Wed, 31 Oct 2012, Felipe Contreras

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Martin Langhoff
Felipe, I'll invite you to reread some of your words: That being said, I did wonder what must be going through his mind to not see that as obvious, (...) Following the guideline of always assuming good faith So perhaps it does apply that you could try to assume good intellectual faith in

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 3:47 PM, Martin Langhoff martin.langh...@gmail.com wrote: Felipe, I'll invite you to reread some of your words: That being said, I did wonder what must be going through his mind to not see that as obvious, (...) Following the guideline of always assuming good faith

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-11-01 Thread Jonathan Nieder
Junio C Hamano wrote: We've been hoping we can do without a rigid code of conduct written down to maintain cordial community focused on technical merits, and instead relied on people's common sense, but sense may not be so common, unfortunately, so we may have to have one. I think that

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Michael J Gruber
[quotes heavily cut down by me] Felipe Contreras venit, vidit, dixit 30.10.2012 21:15: Hi, On Tue, Oct 30, 2012 at 8:33 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On Tue, 30 Oct 2012, Felipe Contreras wrote: But you mentioned something about cooperation, and I've yet to see

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 10:30:50AM +0100, Michael J Gruber wrote: For the record, Johannes is not the only one being kept from looking at this series (further) by the tone of this discussion. Per hominem attacks are neither professional nor helpful. We prefer to discuss code here, just code.

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 10:30 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: [quotes heavily cut down by me] Felipe Contreras venit, vidit, dixit 30.10.2012 21:15: On Tue, Oct 30, 2012 at 8:33 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On Tue, 30 Oct 2012, Felipe

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: This is precisely ad hominem; you are ignoring the code, not because of the code, because of the person. This is as ad hominem as it gets. I am not rejecting your code (I reviewed an early series) but reject the communication style and

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 11:27 AM, Jeff King p...@peff.net wrote: On Wed, Oct 31, 2012 at 10:30:50AM +0100, Michael J Gruber wrote: For the record, Johannes is not the only one being kept from looking at this series (further) by the tone of this discussion. Per hominem attacks are neither

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 4:55 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: This is precisely ad hominem; you are ignoring the code, not because of the code, because of the person. This is as ad hominem as it gets. I am not

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 4:55 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: Didn't think so. The truth of the matter is that it doesn't matter what I do code-wise. Just try, seriously. All right. First of all, I clone the

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Johannes Schindelin
Hi Peff, On Wed, 31 Oct 2012, Jeff King wrote: I really like some of the directions the series is taking, and as the maintainer, I'd like to pick it up. Code-wise, I agree. But there is a big question mark for me still about how it relates to the work in msysgit, especially: - What

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: - What disadvantages? If this implementation goes into git.git, the msysgit one is likely to wane in popularity. What will we be losing by doing so? If the answer is not nothing, how hard

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Jonathan Nieder
Felipe Contreras wrote: On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: I just tested this with junio/next and it seems this issue is still unfixed: instead of reset refs/heads/blub from e7510461b7db54b181d07acced0ed3b1ada072c8 I get

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 7:59 PM, Jonathan Nieder jrnie...@gmail.com wrote: Felipe Contreras wrote: On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: I just tested this with junio/next and it seems this issue is still unfixed: instead of

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 7:04 PM, Felipe Contreras felipe.contre...@gmail.com wrote: How about performance? 174.038642915 seconds time elapsed Compared to; 340.976843750 seconds time elapsed Looks like there's something to improve in this area, but I wouldn't be surprised if

Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Johannes Schindelin
Hi, On Wed, 31 Oct 2012, Felipe Contreras wrote: It doesn't get any more obvious than that. But to each his own. In my opinion, Jonathan does not deserve any of such condescending words. But maybe the Git maintainers are okay with such a tone on this list? Hth, Johannes -- To unsubscribe from

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 9:28 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi, On Wed, 31 Oct 2012, Felipe Contreras wrote: It doesn't get any more obvious than that. But to each his own. In my opinion, Jonathan does not deserve any of such condescending words. But maybe the

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Daniel Barkalow
On Wed, 31 Oct 2012, Felipe Contreras wrote: Hi, On Wed, Oct 31, 2012 at 7:59 PM, Jonathan Nieder jrnie...@gmail.com wrote: Felipe Contreras wrote: On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: I just tested this with junio/next and it seems

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com wrote: And finally, what do more do you expect me to do? About the code, and only the code. The analysis that does in the log messages is an important part of code in this project, so that may be a good place to start. Both Jonathan and J6t asked

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de wrote: On Wed, 31 Oct 2012, Felipe Contreras wrote: It doesn't get any more obvious than that. But to each his own. In my opinion, Jonathan does not deserve any of such condescending words. But maybe the Git maintainers are okay with such a tone

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de wrote: Junio wanted a more general solution, adding infrastructure to the rev-list engine that I did not need -- and did not see the need for, either -- and given the amount of time I had invested in a working remote-hg and given that I needed it

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 12:14 AM, Daniel Barkalow barka...@iabervon.org wrote: I think that may be true where you have next in both places, but I think: $ git checkout -b new-branch master $ git fast-export ^master new-branch ought to emit no commit lines, but needs to emit a reset line.

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:22 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com wrote: And finally, what do more do you expect me to do? About the code, and only the code. The analysis that does in the log messages is an important part of code in this

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:41 AM, Junio C Hamano gits...@pobox.com wrote: Johannes Schindelin johannes.schinde...@gmx.de wrote: Junio wanted a more general solution, adding infrastructure to the rev-list engine that I did not need -- and did not see the need for, either -- and given the amount

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:32 AM, Junio C Hamano gits...@pobox.com wrote: Johannes Schindelin johannes.schinde...@gmx.de wrote: On Wed, 31 Oct 2012, Felipe Contreras wrote: It doesn't get any more obvious than that. But to each his own. In my opinion, Jonathan does not deserve any of such

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 8:47 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Oct 31, 2012 at 7:04 PM, Felipe Contreras felipe.contre...@gmail.com wrote: How about performance? 174.038642915 seconds time elapsed Compared to; 340.976843750 seconds time elapsed

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-30 Thread Felipe Contreras
On Mon, Oct 29, 2012 at 11:06 PM, Jeff King p...@peff.net wrote: On Mon, Oct 29, 2012 at 11:02:31PM +0100, Felipe Contreras wrote: If remote-hg is going to live in contrib, it probably makes sense to have its tests live there, too, like subtree. Probably, I'll check that option. But

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-30 Thread Johannes Schindelin
Hi all, On Mon, 29 Oct 2012, Jeff King wrote: On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: Yeah, the test script is not ready for merging, it needs to check for python, hg, and hg-git. Do you have hg-git installed? No. But it's important that it fail

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 6:20 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: P.S.: I would still recommend to have a detailed look at the 'devel' branch, in particular the commits starting with fast-export: do not refer to non-existing marks and ending with t5801: skip without hg. My

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-30 Thread Johannes Schindelin
Hi Felipe, On Tue, 30 Oct 2012, Felipe Contreras wrote: But you mentioned something about cooperation, and I've yet to see how is it that you are planning to cooperate. If you say you don't have time to spend on this, I don't see why I should worry about testing this series of patches. It

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-30 Thread Felipe Contreras
Hi, On Tue, Oct 30, 2012 at 8:33 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On Tue, 30 Oct 2012, Felipe Contreras wrote: But you mentioned something about cooperation, and I've yet to see how is it that you are planning to cooperate. If you say you don't have time to spend on

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Jeff King
On Sun, Oct 28, 2012 at 04:54:00AM +0100, Felipe Contreras wrote: I've ported the tests from hg-git and made sure that the output from remote-hg matches the output of hg-git. With these extensive tests I would consider this one ready for wide use. Not only do the tests pass, I've compared the

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Felipe Contreras
On Mon, Oct 29, 2012 at 9:50 AM, Jeff King p...@peff.net wrote: On Sun, Oct 28, 2012 at 04:54:00AM +0100, Felipe Contreras wrote: I've ported the tests from hg-git and made sure that the output from remote-hg matches the output of hg-git. With these extensive tests I would consider this

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Felipe Contreras
On Mon, Oct 29, 2012 at 10:26 PM, Jeff King p...@peff.net wrote: On Mon, Oct 29, 2012 at 03:56:39PM +0100, Felipe Contreras wrote: I've ported the tests from hg-git and made sure that the output from remote-hg matches the output of hg-git. With these extensive tests I would consider

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Jeff King
On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: Yeah, the test script is not ready for merging, it needs to check for python, hg, and hg-git. Do you have hg-git installed? No. But it's important that it fail gracefully; I can't even take it in pu if I can't run the

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Felipe Contreras
On Mon, Oct 29, 2012 at 10:56 PM, Jeff King p...@peff.net wrote: On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: Yeah, the test script is not ready for merging, it needs to check for python, hg, and hg-git. Do you have hg-git installed? No. But it's important that

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-29 Thread Jeff King
On Mon, Oct 29, 2012 at 11:02:31PM +0100, Felipe Contreras wrote: If remote-hg is going to live in contrib, it probably makes sense to have its tests live there, too, like subtree. Probably, I'll check that option. But eventually I think it should be installed by default, unless