Re: [PATCH v4 01/11] Add new git-related helper to contrib
On Fri, Apr 26, 2013 at 10:01 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Felipe Contreras wrote: That's fine, I was mostly asking Ramkumar who earlier argued earlier versions of this patch were not understandable. Sorry, still catching up with list emails. At a glance, part 1 looks much better. Will read through more carefully soon. Gentle reminder. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 01/11] Add new git-related helper to contrib
Hi, On Thu, Apr 25, 2013 at 2:59 PM, Felipe Contreras felipe.contre...@gmail.com wrote: This script find people that might be interested in a patch, by going back through the history for each single hunk modified, and finding people that reviewed, acknowledge, signed, or authored the code the patch is modifying. It does this by running 'git blame' incrementally on each hunk, and then parsing the commit message. After gathering all the relevant people, it groups them to show what exactly was their role when the participated in the development of the relevant commit, and on how many relevant commits they participated. They are only displayed if they pass a minimum threshold of participation. Is this patch still not understandable? If so, I would gladly strip away functionality, like the ability to show the roles. But for the functionality it provides, I don't see how it could be any simpler. Sure, code comments might help, but first I would like to make the code as self-documenting as possible, so I would give a try at a simplified version first, and then perhaps adding a Person object. Better for me if the code was good enough as it is though. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 01/11] Add new git-related helper to contrib
Felipe Contreras felipe.contre...@gmail.com writes: On Thu, Apr 25, 2013 at 2:59 PM, Felipe Contreras felipe.contre...@gmail.com wrote: This script find people that might be interested in a patch, by going back through the history for each single hunk modified, and finding people that reviewed, acknowledge, signed, or authored the code the patch is modifying. It does this by running 'git blame' incrementally on each hunk, and then parsing the commit message. After gathering all the relevant people, it groups them to show what exactly was their role when the participated in the development of the relevant commit, and on how many relevant commits they participated. They are only displayed if they pass a minimum threshold of participation. Is this patch still not understandable? Among the people who review patches here and give usable feedback, earlier this week Peff said he is away from his mailbox for the rest of the week, and I am not reviewing any new topics that are not in 'next', being busy in preparation for -rc0, so I wouldn't be able to answer that question. I do not know about the others, but it is understandable from time to time there is a period a series is not being reviewed by anybody. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 01/11] Add new git-related helper to contrib
On Fri, Apr 26, 2013 at 6:01 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: On Thu, Apr 25, 2013 at 2:59 PM, Felipe Contreras felipe.contre...@gmail.com wrote: This script find people that might be interested in a patch, by going back through the history for each single hunk modified, and finding people that reviewed, acknowledge, signed, or authored the code the patch is modifying. It does this by running 'git blame' incrementally on each hunk, and then parsing the commit message. After gathering all the relevant people, it groups them to show what exactly was their role when the participated in the development of the relevant commit, and on how many relevant commits they participated. They are only displayed if they pass a minimum threshold of participation. Is this patch still not understandable? Among the people who review patches here and give usable feedback, earlier this week Peff said he is away from his mailbox for the rest of the week, and I am not reviewing any new topics that are not in 'next', being busy in preparation for -rc0, so I wouldn't be able to answer that question. I do not know about the others, but it is understandable from time to time there is a period a series is not being reviewed by anybody. That's fine, I was mostly asking Ramkumar who earlier argued earlier versions of this patch were not understandable. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 01/11] Add new git-related helper to contrib
Felipe Contreras wrote: That's fine, I was mostly asking Ramkumar who earlier argued earlier versions of this patch were not understandable. Sorry, still catching up with list emails. At a glance, part 1 looks much better. Will read through more carefully soon. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
