Re: [PATCH v4 06/45] Move sequencer to builtin
On Sun, Jun 9, 2013 at 7:07 PM, Ramkumar Ramachandra wrote: > Antoine Pelisse wrote: >> I don't understand why the code doesn't belong to libgit.a, and how >> it's gonna make it more "clean". I can see that it is needed only by >> revert and cherry-pick, but is that the only reason ? > > Perhaps this will help? [1]. Join into the discussion. > > [1]: http://thread.gmane.org/gmane.comp.version-control.git/226845 OK Thanks, missed that. I'm catching up the last two hours of discussions. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 06/45] Move sequencer to builtin
Antoine Pelisse wrote: > I don't understand why the code doesn't belong to libgit.a, and how > it's gonna make it more "clean". I can see that it is needed only by > revert and cherry-pick, but is that the only reason ? Perhaps this will help? [1]. Join into the discussion. [1]: http://thread.gmane.org/gmane.comp.version-control.git/226845 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 06/45] Move sequencer to builtin
On Sun, Jun 9, 2013 at 12:02 PM, Antoine Pelisse wrote: > On Sun, Jun 9, 2013 at 6:40 PM, Felipe Contreras > wrote: >> >> This code is only useful for cherry-pick and revert built-ins, nothing >> else, so let's make it a builtin object. >> >> The first source file that doesn't generate a git-foo builtin, but does >> go into the builtin library. Hopefully the first of many to clean >> libgit.a. > > Hey Felipe, > I don't understand why the code doesn't belong to libgit.a, and how > it's gonna make it more "clean". I can see that it is needed only by > revert and cherry-pick, but is that the only reason ? > > Thanks for taking the time to enlighten me :) A libgit library should be useful for things other than builtin commands. Eventually libgit.a should be similar to libgit2, therefore if libgit2 wouldn't want sequencer.c in it (it doesn't) neither should we want this code in libgit.a. It belongs in builtin/lib.a. If we don't start moving non-library stuff out of libgit.a, libgit.a will never be a library. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 06/45] Move sequencer to builtin
On Sun, Jun 9, 2013 at 6:40 PM, Felipe Contreras wrote: > > This code is only useful for cherry-pick and revert built-ins, nothing > else, so let's make it a builtin object. > > The first source file that doesn't generate a git-foo builtin, but does > go into the builtin library. Hopefully the first of many to clean > libgit.a. Hey Felipe, I don't understand why the code doesn't belong to libgit.a, and how it's gonna make it more "clean". I can see that it is needed only by revert and cherry-pick, but is that the only reason ? Thanks for taking the time to enlighten me :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
