Re: [PATCH v4 20/25] sequencer: refactor write_message()

Hi Junio, On Fri, 21 Oct 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> Ah, make that four steps. The final one is: > >> > >> - add append_eol parameter that nobody uses at this step in the > >> series. > >> > >> This is a new feature

Re: [PATCH v4 20/25] sequencer: refactor write_message()

Johannes Schindelin writes: >> Ah, make that four steps. The final one is: >> >> - add append_eol parameter that nobody uses at this step in the >> series. >> >> This is a new feature to the helper. While it is OK to have it as a >> preparatory step in

Re: [PATCH v4 20/25] sequencer: refactor write_message()

Hi Junio, On Thu, 20 Oct 2016, Junio C Hamano wrote: > Junio C Hamano writes: > > > If I were doing this, I would make this into three separate steps: > > > > - move the strbuf_release(msgbuf) to the caller in > > do_pick_commit(); > > > > - add the missing

Re: [PATCH v4 20/25] sequencer: refactor write_message()

Junio C Hamano writes: > If I were doing this, I would make this into three separate steps: > > - move the strbuf_release(msgbuf) to the caller in > do_pick_commit(); > > - add the missing rollback_lock_file(), which is a bugfix; and > then finally > >

Re: [PATCH v4 20/25] sequencer: refactor write_message()

Johannes Schindelin writes: > The write_message() function safely writes an strbuf to a file. > Sometimes it is inconvenient to require an strbuf, though: the text to > be written may not be stored in a strbuf, or the strbuf should not be > released after writing. > >