Re: [PATCH v4 3/3] Add colors to interactive git-clean

2013-05-02 Thread Jiang Xin
2013/5/2 Matthieu Moy :
> Jiang Xin  writes:
>
>> Show help, error messages, and prompt in colors for interactive
>> git-clean.
>
> I find the red WARNING a bit agressive. Also, the NOTE: is the same
> color as the WARNING, hence visually similar. I first thought it was
> repeating the same message. I think it would make more sense to use
> default color, black,

Will use new style -- CLEAN_COLOR_HEADER (GIT_COLOR_BOLD)
as header for interactive git-clean (i.e.  WARNING)

> for the NOTE, by analogy with "git add -p" which
> uses it for patch hunk headers (somehow, this is the question you're
> replying to after the blue prompt below).

I agree. NOTE should only be displayed once, and will be fixed
in patch 3/1 of next reroll.

--
Jiang Xin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 3/3] Add colors to interactive git-clean

2013-05-02 Thread Matthieu Moy
Jiang Xin  writes:

> Show help, error messages, and prompt in colors for interactive
> git-clean.

I find the red WARNING a bit agressive. Also, the NOTE: is the same
color as the WARNING, hence visually similar. I first thought it was
repeating the same message. I think it would make more sense to use
default color, black, for the NOTE, by analogy with "git add -p" which
uses it for patch hunk headers (somehow, this is the question you're
replying to after the blue prompt below).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html