Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

2016-09-15 Thread Thomas Gummerer
On 09/14, Junio C Hamano wrote: > I've queued this trivial SQUASH??? on top, which I think should be > squashed into 3/4. Yeah, I missed this. The SQUASH??? definitely makes sense, would be great if you could just squash that in. > Thanks. Thanks the reviews and helping me getting the series

Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

2016-09-14 Thread Junio C Hamano
I've queued this trivial SQUASH??? on top, which I think should be squashed into 3/4. Thanks. read-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index 2445e30..c2b2e97 100644 --- a/read-cache.c +++ b/read-cache.c @@ -779,7 +779,7 @@ int

Re: [PATCH v4 3/4] read-cache: introduce chmod_index_entry

2016-09-14 Thread Junio C Hamano
Thomas Gummerer writes: > As there are chmod options for both add and update-index, introduce a > new chmod_index_entry function to do the work. Use it in update-index, > while it will be used in add in the next patch. > > Signed-off-by: Thomas Gummerer