Re: [PATCH v5 00/10] The final building block for a faster rebase -i

2017-06-16 Thread Johannes Schindelin
Hi Junio,

On Thu, 15 Jun 2017, Junio C Hamano wrote:

> Johannes Schindelin  writes:
> 
> > Changes since v4:
> >
> > - replaced the "sha1s" part of the names by "ids", to reflect the
> >   current effort to move away from the cryptographically unsafe SHA-1
> >
> > - replaced the confusing term "instruction sheet" in an error message by
> >   the more commonly used "todo list"
> 
> Both are good changes.  Once this follows the API properly, it would
> be perfect.

Okay, then drop it. What you call "properly", I call bad programming, and
I won't do it.

Ciao,
Dscho


Re: [PATCH v5 00/10] The final building block for a faster rebase -i

2017-06-15 Thread Junio C Hamano
Johannes Schindelin  writes:

> Changes since v4:
>
> - replaced the "sha1s" part of the names by "ids", to reflect the
>   current effort to move away from the cryptographically unsafe SHA-1
>
> - replaced the confusing term "instruction sheet" in an error message by
>   the more commonly used "todo list"

Both are good changes.  Once this follows the API properly, it would
be perfect.

Will replace.