Re: [PATCH v5 1/2] xread, xwrite: Limit size of IO, fixing IO of 2GB and more on Mac OS X

2013-08-21 Thread Torsten Bögershausen
On 2013-08-20 08.43, Steffen Prohaska wrote: [] Thanks for V5. It was tested OK on my system here. (And apologies for recommending a wrapper on top of a wrapper). One question is left: As xread() is tolerant against EAGAIN and especially EINTR, could it make sense to replace read() with xread() e

Re: [PATCH v5 1/2] xread, xwrite: Limit size of IO, fixing IO of 2GB and more on Mac OS X

2013-08-20 Thread Junio C Hamano
Steffen Prohaska writes: > diff --git a/wrapper.c b/wrapper.c > index 6a015de..97e3cf7 100644 > --- a/wrapper.c > +++ b/wrapper.c > @@ -131,6 +131,14 @@ void *xcalloc(size_t nmemb, size_t size) > } > > /* > + * Limit size of IO chunks, because huge chunks only cause pain. OS X 64-bit > + * b