Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Johannes Schindelin
Hi Junio, On Sun, 25 Nov 2012, Junio C Hamano wrote: From: Johannes Schindelin johannes.schinde...@gmx.de Subject: Re: [PATCH v3 4/4] fast-export: make sure refs are updated properly Date: Fri, 2 Nov 2012 16:17:14 +0100 (CET) Message-ID:

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: If you changed your stance on the patch Sverre and I sent to fix this, we could get a non-partial fix for this. This is long time ago so I may be misremembering the details, but I thought the original patch was (ab)using object flags to

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Johannes Schindelin
Hi Junio, On Mon, 26 Nov 2012, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: If you changed your stance on the patch Sverre and I sent to fix this, we could get a non-partial fix for this. This is long time ago so I may be misremembering the details, but

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Sverre Rabbelier
On Mon, Nov 26, 2012 at 11:26 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote: We added rev_cmdline_info since then so that we can tell what refs were given from the command line in what way, and I thought that we applied a patch from Sverre that uses it instead of the object flags.

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-26 Thread Junio C Hamano
Sverre Rabbelier srabbel...@gmail.com writes: On Mon, Nov 26, 2012 at 11:26 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote: We added rev_cmdline_info since then so that we can tell what refs were given from the command line in what way, and I thought that we applied a patch from

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-25 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: On Wed, Nov 21, 2012 at 8:48 PM, Jeff King p...@peff.net wrote: ... I would like to understand that that even means. What behavior is currently broken? I do not know if this is the same as what Peff was referring to, but I found this

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 11:30 PM, Max Horn m...@quendi.de wrote: 2) Some are interfaces to foreign systems (bzr, hg, mediawiki, ...). They cannot use sha1s and must use marks (at least that is how I understand felipe's explanation). These tools use import combined with either export, or

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 8:48 PM, Jeff King p...@peff.net wrote: On Tue, Nov 20, 2012 at 09:08:36PM -0800, Junio C Hamano wrote: With such a one-sided discussion, I've been having a hard time convincing myself if Felipe's effort is making the interface better, or just breaking it even more for

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-22 Thread Max Horn
On 21.11.2012, at 06:08, Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Never mind that others have said that that's not the current interface (I don't yet see why it would be a good interface after a transition, but maybe it would be). Still, hopefully that clarifies the

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-21 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: They have been marked as UNINTERESTING for a reason, lets respect that. ... The current behavior is most certainly not what we want. After this patch, nothing gets exported, because nothing was selected (everything is UNINTERESTING). The

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-21 Thread Jeff King
On Tue, Nov 20, 2012 at 09:08:36PM -0800, Junio C Hamano wrote: With such a one-sided discussion, I've been having a hard time convincing myself if Felipe's effort is making the interface better, or just breaking it even more for existing remote helpers, only to fit his world model better.

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Of course, transport-helper shouldn't even be specifying the negative (^) refs, but that's another story. Hrm, I am not sure I understand what you mean by this. How should it be telling the fast-export up to what commit the receiving end

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Jonathan Nieder
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: Of course, transport-helper shouldn't even be specifying the negative (^) refs, but that's another story. Hrm, I am not sure I understand what you mean by this. How should it be telling the fast-export up to what

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 5:17 AM, Jonathan Nieder jrnie...@gmail.com wrote: Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: Of course, transport-helper shouldn't even be specifying the negative (^) refs, but that's another story. Hrm, I am not sure I understand what

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Never mind that others have said that that's not the current interface (I don't yet see why it would be a good interface after a transition, but maybe it would be). Still, hopefully that clarifies the intended meaning. Care to explain how the

Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-20 Thread Felipe Contreras
On Wed, Nov 21, 2012 at 6:08 AM, Junio C Hamano gits...@pobox.com wrote: I see Felipe keeps repeating that there are bugs, and keeps posting patches to change fast-export, but I haven't seen a concrete No, the reason why you see these problems is because you are not using the interface