Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Dan Jacques
On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason wrote: > > I'll add a "NO_RUNTIME_PREFIX_PERL" flag as per avarab@'s suggestion as a > > potential mitigation if a problem does end up arising in Windows builds, > > with a note that NO_RUNTIME_PREFIX_PERL can be deleted if everything seems > > to be

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 08 2018, Dan Jacques jotted: > On 2018-01-08 20:27, Johannes Schindelin wrote: > >> > Maybe we covered this in previous submissions, but refresh my memory, >> > why is the *_PERL define still needed? Reading this explanation doesn't >> > make sense to me, but I'm probably missing

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Dan Jacques
On 2018-01-08 20:27, Johannes Schindelin wrote: > > Maybe we covered this in previous submissions, but refresh my memory, > > why is the *_PERL define still needed? Reading this explanation doesn't > > make sense to me, but I'm probably missing something. > > If the reason is to accommodate

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Junio C Hamano
Johannes Schindelin writes: > On Mon, 8 Jan 2018, Dan Jacques wrote: > >> On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason replied: >> >> >>+# it. This is intentionally separate from RUNTIME_PREFIX so that >> >>notably Windows +# can hard-code Perl library paths while

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Johannes Schindelin
Hi, On Mon, 8 Jan 2018, Dan Jacques wrote: > On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason replied: > > >>+# it. This is intentionally separate from RUNTIME_PREFIX so that > >>notably Windows +# can hard-code Perl library paths while still > >>enabling RUNTIME_PREFIX +# resolution. > > > > Maybe

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Johannes Schindelin
Hi, On Mon, 8 Jan 2018, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jan 08 2018, Dan Jacques jotted: > > From 3/3 (not not send 2 e-mails): > > >+# it. This is intentionally separate from RUNTIME_PREFIX so that notably > >Windows > >+# can hard-code Perl library paths while still enabling

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 08 2018, Dan Jacques jotted: > On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason replied: >>>+# it. This is intentionally separate from RUNTIME_PREFIX so that notably >>>Windows >>>+# can hard-code Perl library paths while still enabling RUNTIME_PREFIX >>>+# resolution. >> >> Maybe we

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Dan Jacques
On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason replied: > Thanks, applied this on top of next and it works for me, i.e. install to > /tmp/git and move to /tmp/git2 = works for me. Comments below. Good to hear! I've run this through a few machines at my disposal, but the more hands on the better.

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

2018-01-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 08 2018, Dan Jacques jotted: Thanks, applied this on top of next and it works for me, i.e. install to /tmp/git and move to /tmp/git2 = works for me. Comments below. > Enabling RUNTIME_PREFIX_PERL overrides the system-specific Perl script > installation path generated by MakeMaker to