Jeremiah Mahler jmmah...@gmail.com writes:
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 9c80633..049493d 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -762,6 +762,38 @@ test_expect_success 'format-patch --signature=
suppresses signatures' '
Junio C Hamano gits...@pobox.com writes:
Jeremiah Mahler jmmah...@gmail.com writes:
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 9c80633..049493d 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -762,6 +762,38 @@ test_expect_success
On Wed, May 21, 2014 at 02:24:27PM -0700, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
...
It seems you sent v7 before I had a chance to comment on this one.
The above was merely it would be nicer... and I am OK as-is. The
comments on the rest are a bit more serious,
On Wed, May 21, 2014 at 02:13:06PM -0700, Junio C Hamano wrote:
Jeremiah Mahler jmmah...@gmail.com writes:
...
! grep ^-- \$ output
...
We have been trying not to do the above in recent test updates. It
would be nice if this set-up did not have to be outside of the usual
Jeremiah Mahler jmmah...@gmail.com writes:
On Wed, May 21, 2014 at 02:13:06PM -0700, Junio C Hamano wrote:
Jeremiah Mahler jmmah...@gmail.com writes:
...
! grep ^-- \$ output
...
We have been trying not to do the above in recent test updates. It
would be nice if this set-up did
On Wed, May 21, 2014 at 02:58:42PM -0700, Junio C Hamano wrote:
! grep ^-- \$ output
...
We have been trying not to do the above in recent test updates. It
would be nice if this set-up did not have to be outside of the usual
test_expect_success structure.
Jeff
On Wed, May 21, 2014 at 02:58:42PM -0700, Junio C Hamano wrote:
Jeremiah Mahler jmmah...@gmail.com writes:
...
The problem is a cat you added outside test_expect_*; the recent
push is to have as little executable outside them, especially the
set-up code to prepare for the real tests.
i.e.
Jeff King p...@peff.net writes:
I think he is responding to my earlier request to use test_must_fail
instead of !. But there is a subtlety there he does not know, which
is that we typically only use the former for git programs, and rely on
! for normal Unix commands.
Ok, that explains it.
On Wed, May 21, 2014 at 03:15:55PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Yeah, placing it in its own setup may be the best. There are quite
a many set-ups outside the tests in this script from the olden days,
so I am OK if left it as-is and have a separate clean-up
Jeremiah Mahler jmmah...@gmail.com writes:
Below is one of the updated test cases.
test_expect_success 'format-patch --signature-file=mail-signature' '
cat mail-signature -\EOF
Test User test.em...@kernel.org
http://git.kernel.org/cgit/git/git.git
Jeremiah Mahler jmmah...@gmail.com writes:
On Wed, May 21, 2014 at 03:15:55PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Yeah, placing it in its own setup may be the best. There are quite
a many set-ups outside the tests in this script from the olden days,
so I am OK if
On Wed, May 21, 2014 at 03:37:11PM -0700, Junio C Hamano wrote:
Jeremiah Mahler jmmah...@gmail.com writes:
Below is one of the updated test cases.
test_expect_success 'format-patch --signature-file=mail-signature' '
cat mail-signature -\EOF
Test User test.em...@kernel.org
12 matches
Mail list logo
