On Mon, Nov 19, 2012 at 7:55 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> The second patch is new, in order for users to get the same features when
>> sourcing the bash script (they don't need to change anything). They'll get a
>> warning suggesting to check the new script git-completion.zsh. Eventually,
>> that
>> support would be dropped from the bash script.
>>
>> Some people were suggesting something like this, so here it is.
>>
>> Can we merge the zsh wrapper now?
>>
>> Felipe Contreras (2):
>> completion: add new zsh completion
>> completion: start moving to the new zsh completion
>>
>> contrib/completion/git-completion.bash | 104
>> +++--
>> contrib/completion/git-completion.zsh | 78 +
>> 2 files changed, 139 insertions(+), 43 deletions(-)
>> create mode 100644 contrib/completion/git-completion.zsh
>
> Thanks; I am a bit puzzled as to the progression of this series, as
> it spanned many months. I *think* the following are the previous
> ones, but I may be mixing up v$n patches for other series, so just
> to make sure (please correct if I am mistaken):
>
> * (v1) http://thread.gmane.org/gmane.comp.version-control.git/189310
>with only git-completion.zsh without any changes to the bash
>side;
Yes, and with a lot of code that is not strictly needed.
> * (v2) http://thread.gmane.org/gmane.comp.version-control.git/189381
>without bash side changes;
Yes, also with more code.
> * (v3) http://thread.gmane.org/gmane.comp.version-control.git/196720
>without bash side changes;
Yes, now it's simpler due to changes in bash side already in.
> * (v6) http://thread.gmane.org/gmane.comp.version-control.git/208170
>with COMPREPLY changes;
Yeap.
> * This one, with removal of zsh specific workarounds from bash
>completion script.
Yes, although that is a separate patch.
> I do not care too much about how v4 and v5 looked like; I primarily
> am interested in knowing if I can discard 208170 from my inbox
> safely ;-).
Yes you can. The rest of the patches I sent in a different series.
Cheers.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
