Re: [PATCH v6 0/6] recursively grep across submodules

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 09:45:47AM -0800, Brandon Williams wrote: > Yeah I was trying to think through these scenarios myself last night. > And like you found it seemed alright to let the child process deal with > the .git file/dir as long as once actually exists at that path. If one > didn't

Re: [PATCH v6 0/6] recursively grep across submodules

2016-12-01 Thread Brandon Williams
On 11/30, Jeff King wrote: > On Wed, Nov 30, 2016 at 05:28:28PM -0800, Brandon Williams wrote: > > > v6 fixes a race condition which existed in the 'is_submodule_populated' > > function. Instead of calling 'resolve_gitdir' to check for the existance > > of a > > .git file/directory, use 'stat'.

Re: [PATCH v6 0/6] recursively grep across submodules

2016-11-30 Thread Jeff King
On Wed, Nov 30, 2016 at 05:28:28PM -0800, Brandon Williams wrote: > v6 fixes a race condition which existed in the 'is_submodule_populated' > function. Instead of calling 'resolve_gitdir' to check for the existance of a > .git file/directory, use 'stat'. 'resolve_gitdir' calls 'chdir' which can