Re: [PATCH v7 03/12] revert/cherry-pick: add --quiet option

2014-04-24 Thread Felipe Contreras
Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
> > @@ -635,9 +637,10 @@ static int do_pick_commit(struct commit *commit, 
> > struct replay_opts *opts)
> > }
> >
> > if (opts->skip_empty && is_index_unchanged() == 1) {
> > -   warning(_("skipping %s... %s"),
> > -   find_unique_abbrev(commit->object.sha1, 
> > DEFAULT_ABBREV),
> > -   msg.subject);
> > +   if (!opts->quiet)
> > +   warning(_("skipping %s... %s"),
> > +   find_unique_abbrev(commit->object.sha1, 
> > DEFAULT_ABBREV),
> > +   msg.subject);
> 
> Personally, I don't see much value in inventing a new option for
> suppressing one message.

It's not one message; it's two messages from cherry-pick itself, and all the
messages from `git commit`. Didn't we alread discuss this?

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v7 03/12] revert/cherry-pick: add --quiet option

2014-04-24 Thread Ramkumar Ramachandra
Felipe Contreras wrote:
> @@ -635,9 +637,10 @@ static int do_pick_commit(struct commit *commit, struct 
> replay_opts *opts)
> }
>
> if (opts->skip_empty && is_index_unchanged() == 1) {
> -   warning(_("skipping %s... %s"),
> -   find_unique_abbrev(commit->object.sha1, 
> DEFAULT_ABBREV),
> -   msg.subject);
> +   if (!opts->quiet)
> +   warning(_("skipping %s... %s"),
> +   find_unique_abbrev(commit->object.sha1, 
> DEFAULT_ABBREV),
> +   msg.subject);

Personally, I don't see much value in inventing a new option for
suppressing one message.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html