Re: [PATCH v7 08/10] convert: modernize tests

2016-09-11 Thread Lars Schneider 

> On 09 Sep 2016, at 00:05, Stefan Beller  wrote:
> 
> On Thu, Sep 8, 2016 at 11:21 AM,   wrote:
>> From: Lars Schneider 
>> 
>> Use `test_config` to set the config, check that files are empty with
>> `test_must_be_empty`, compare files with `test_cmp`, and remove spaces
>> after ">" and "<".
>> 
>> Please note that the "rot13" filter configured in "setup" keeps using
>> `git config` instead of `test_config` because subsequent tests might
>> depend on it.
>> 
>> Signed-off-by: Lars Schneider 
>> ---
> 
> Makes sense & Reviewed-by "Stefan Beller "

Thank you,
Lars

Re: [PATCH v7 08/10] convert: modernize tests

2016-09-08 Thread Stefan Beller 
On Thu, Sep 8, 2016 at 11:21 AM,   wrote:
> From: Lars Schneider 
>
> Use `test_config` to set the config, check that files are empty with
> `test_must_be_empty`, compare files with `test_cmp`, and remove spaces
> after ">" and "<".
>
> Please note that the "rot13" filter configured in "setup" keeps using
> `git config` instead of `test_config` because subsequent tests might
> depend on it.
>
> Signed-off-by: Lars Schneider 
> ---

Makes sense & Reviewed-by "Stefan Beller "

Thanks,
Stefan