Re: [PATCH v7 1/2] builtin/config.c: treat type specifiers singularly

2018-04-09 Thread Eric Sunshine
On Mon, Apr 9, 2018 at 10:12 PM, Taylor Blau wrote: > On Tue, Apr 10, 2018 at 10:22:25AM +0900, Junio C Hamano wrote: >> I suspect that it may be OK to switch to last-one-wins, but then we >> should give a justification that is a bit stronger than "we want to >> avoid

Re: [PATCH v7 1/2] builtin/config.c: treat type specifiers singularly

2018-04-09 Thread Taylor Blau
On Tue, Apr 10, 2018 at 10:22:25AM +0900, Junio C Hamano wrote: > Taylor Blau writes: > > > Internally, we represent `git config`'s type specifiers as a bitset > > using OPT_BIT. 'bool' is 1<<0, 'int' is 1<<1, and so on. This technique > > allows for the representation of

Re: [PATCH v7 1/2] builtin/config.c: treat type specifiers singularly

2018-04-09 Thread Junio C Hamano
Taylor Blau writes: > Internally, we represent `git config`'s type specifiers as a bitset > using OPT_BIT. 'bool' is 1<<0, 'int' is 1<<1, and so on. This technique > allows for the representation of multiple type specifiers in the `int > types` field, but this