Re: [PATCH v7 3/4] tests: add new test for the url_normalize function

2013-07-22 Thread Junio C Hamano
I suspect that files under t/t5200/ were not suiable for e-mail transmission. Can you regenerate this after running: $ echo '/t/t5200/* binary' .git/info/attributes or better yet with: diff --git a/t/.gitattributes b/t/.gitattributes index 1b97c54..6240ed2 100644 --- a/t/.gitattributes +++

Re: [PATCH v7 3/4] tests: add new test for the url_normalize function

2013-07-22 Thread Kyle J. McKay
On Jul 21, 2013, at 22:15, Junio C Hamano wrote: Kyle J. McKay mack...@gmail.com writes: +test_expect_success 'url general escapes' ' + ! test-url-normalize http://x.y?%fg; + test $(test-url-normalize -p X://W/%7e%41^%3a) = x://w/~A%5E %3A + test $(test-url-normalize -p X://W/:/?#[]@)

Re: [PATCH v7 3/4] tests: add new test for the url_normalize function

2013-07-22 Thread Kyle J. McKay
I was able to apply the patch I got back. It was marked as charset=ISO-8859-1 so it should be fine. I wasn't sure how best to handle those though, so I will send a new version with the suggested .gitattributes patch included as well. On Jul 21, 2013, at 23:45, Junio C Hamano wrote: I

Re: [PATCH v7 3/4] tests: add new test for the url_normalize function

2013-07-21 Thread Junio C Hamano
Kyle J. McKay mack...@gmail.com writes: +test_expect_success 'url general escapes' ' + ! test-url-normalize http://x.y?%fg; + test $(test-url-normalize -p X://W/%7e%41^%3a) = x://w/~A%5E%3A + test $(test-url-normalize -p X://W/:/?#[]@) = x://w/:/?#[]@ + test