Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-08-16 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Robin Rosenberg robin.rosenb...@dewire.com writes: Just a couple of nitpicks. Polishing is always good and better late than never, but for a topic that has long been graduated to 'master' already, it would be easier to review and discuss if it came

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Robin Rosenberg
Just a couple of nitpicks. Torsten Bögershausen skrev 2012-07-08 15.50: diff --git a/compat/precompose_utf8.c b/compat/precompose_utf8.c [...] +static size_t has_utf8(const char *s, size_t maxlen, size_t *strlen_c) +{ + const uint8_t *utf8p = (const uint8_t*) s; + size_t

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Junio C Hamano
Robin Rosenberg robin.rosenb...@dewire.com writes: Just a couple of nitpicks. Polishing is always good and better late than never, but for a topic that has long been graduated to 'master' already, it would be easier to review and discuss if it came as a patch form relative to the codebase