Re: [PATCH v9 2/2] test-config: add tests for the config_set API

2014-07-15 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: Expose the `config_set` C API as a set of simple commands in order to facilitate testing. Add tests for the `config_set` API as well as for `git_config_get_*()` family for the usual config files. Signed-off-by: Matthieu Moy matthieu@imag.fr

Re: [PATCH v9 2/2] test-config: add tests for the config_set API

2014-07-15 Thread Tanay Abhra
On 7/15/2014 9:27 PM, Junio C Hamano wrote: +test_expect_success 'setup default config' ' +cat .git/config \EOF So the default .git/config that was prepared by git init is discarded and replaced with this? Shouldn't it be cat .git/config \EOF instead? Most of tests like

Re: [PATCH v9 2/2] test-config: add tests for the config_set API

2014-07-15 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: ... I need it for test_expect_success 'proper error on error in default config files' ' which requires me to compare the line no at which the error was found. I see. We may want to later rethink the way you validate the line numbers, but in the meantime