Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-17 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: I have a question about renaming git_config() to git_config_raw(). I was working on a patch and I am getting stuck here. It fails in t1001, t1020 t4018. The reason for the last test failure is unknown right now. For the first two, it boils down to this,

Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-17 Thread Tanay Abhra
On 7/17/2014 3:31 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: I have a question about renaming git_config() to git_config_raw(). I was working on a patch and I am getting stuck here. It fails in t1001, t1020 t4018. The reason for the last test failure is unknown right

Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-17 Thread Matthieu Moy
Matthieu Moy matthieu@grenoble-inp.fr writes: Tanay Abhra tanay...@gmail.com writes: I have a question about renaming git_config() to git_config_raw(). I was working on a patch and I am getting stuck here. It fails in t1001, t1020 t4018. The reason for the last test failure is unknown

Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-17 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: I am searching for a more elegant solution to this problem. The efficient (not sure about elegant) solution would be to keep one configset per file, and re-parse only the files needed. I find the solution I posted in the other thread relatively elegant:

Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-17 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Matthieu Moy matthieu@grenoble-inp.fr writes: Tanay Abhra tanay...@gmail.com writes: I have a question about renaming git_config() to git_config_raw(). I was working on a patch and I am getting stuck here. It fails in t1001, t1020

Re: [PATCH v9r2 1/2] add `config_set` API for caching config-like files

2014-07-16 Thread Tanay Abhra
On 7/16/2014 9:36 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: implemented as a thin wrapper around the `config_set` API. Signed-off-by: Matthieu Moy matthieu@imag.fr Signed-off-by: Tanay Abhra tanay...@gmail.com Documentation/technical/api-config.txt | 137