On Thu, Jan 31, 2013 at 10:18:40AM -0800, Stephen Boyd wrote: > Failing to close the stderr pipe in verify_signed_buffer() causes > git to run out of file descriptors if there are many calls to > verify_signed_buffer(). An easy way to trigger this is to run > > git log --show-signature --merges | grep "key" > > on the linux kernel git repo. Eventually it will fail with > > error: cannot create pipe for gpg: Too many open files > error: could not run gpg. > > Close the stderr pipe so that this can't happen. > > Suggested-by: Jeff King <p...@peff.net> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org>
Thanks, looks good to me (obviously :) ). The rest of the series looks fine, too, with the caveat I mentioned on 2/3. Thanks for fixing this. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
